-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.16
-
Fix Version/s: 1.17, Some future release
-
Component/s: None
-
Labels:
-
Story Points:3
-
Sprint:DEV-27/05/2015
-
User Requests Number:1
-
Affect Type:Technical
1. Wrong protection of #include <proc/readproc.h> in src/corelibs/U2Core/src/globals/AppResources.cpp.
It is guarded by #if defined(Q_OS_LINUX) || defined(Q_OS_FREEBSD), but
this header does not exist on FreeBSD; it is part of procps/libproc
package, which is Linux-specific. I would suggest that your developers
either try to git rid of procps dependency and remove it completely, or
adjust "#if defined" expression properly.
2. BOM present in src/include/U2Formats/MysqlUpgradeTask.h file, which
upsets gcc4.2 for example (does not build with it). It should be removed
to make this file purely ASCII.
3. NUMBER_OF_TESTS_IN_SUTIE macro is undefined on FreeBSD because of
non-exhaustive #ifdef test in src/corelibs/U2Test/src/gui_tests/GUITestLauncher.cpp
file. Small patch that would fix it:
@@ -36,7 +36,7 @@
#define TIMEOUT 480000
-#ifdef Q_OS_LINUX
+#ifdef Q_OS_UNIX
#define NUMBER_OF_TESTS_IN_SUTIE 500
#endif
#ifdef Q_OS_MAC